Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Santize @ for discord #22

Merged
merged 3 commits into from
Dec 13, 2023
Merged

Santize @ for discord #22

merged 3 commits into from
Dec 13, 2023

Conversation

pepbutler
Copy link
Contributor

Santise mc -> discord messaging by removing "@"

Thatsmusic99
Thatsmusic99 reviewed Dec 12, 2023
View reviewed changes
Copy link
Member

@Thatsmusic99 Thatsmusic99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if we want to remove the @ symbol altogether, an alternative suggested was adding the ​​U+200B character after the symbol which has no visible effect

@sapphyree
Copy link

Not sure the problem with removing the @ and replacing it with " at " instead?

@pepbutler
Copy link
Contributor Author

Yeah i'll do "(at)" since it can be used in correct contexts.

@Thatsmusic99 Thatsmusic99 merged commit 83f19ee into CSSUoB:master Dec 13, 2023
2 of 3 checks passed
@pepbutler pepbutler deleted the fix/santise branch December 13, 2023 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Thatsmusic99 Thatsmusic99 Thatsmusic99 approved these changes

@MattyTheHacker MattyTheHacker Awaiting requested review from MattyTheHacker MattyTheHacker is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pepbutler @sapphyree @Thatsmusic99 @MattyTheHacker